Skip to content

Replace storage banners faq links with docs links

Ammar Alakkad requested to merge 432317-replace-storage-faq-with-docs-links into master

What does this MR do and why?

It updates the links in storage enforcement and pre-enforcement banners as follows:

Current URL New URL
https://about.gitlab.com/pricing/faq-efficient-free-tier/#storage-limits-on-gitlab-saas-free-tier removed
https://about.gitlab.com/pricing/faq-efficient-free-tier/#next-steps https://docs.gitlab.com/ee/user/usage_quotas.html#namespace-storage-limit

It also updates the copy inside the banners slightly as suggested by Technical Writing.

Screenshots or screen recordings

Before After
Screenshot_2023-12-08_at_10.57.54 Screenshot_2023-12-08_at_10.50.37

How to set up and validate locally

Apply the following patch

e.g. copy then pbpaste | git apply -

diff --git a/ee/app/components/namespaces/combined_storage_users/base_alert_component.rb b/ee/app/components/namespaces/combined_storage_users/base_alert_component.rb
index 49ac28542803..1171ec20f3b4 100644
--- a/ee/app/components/namespaces/combined_storage_users/base_alert_component.rb
+++ b/ee/app/components/namespaces/combined_storage_users/base_alert_component.rb
@@ -20,6 +20,7 @@ def initialize(root_namespace:, user:, content_class:)
       attr_reader :root_namespace, :user, :content_class
 
       def render?
+        return true
         return false unless over_both_limits?(root_namespace)
 
         !dismissed?
diff --git a/ee/app/components/namespaces/storage/pre_enforcement_alert_component.rb b/ee/app/components/namespaces/storage/pre_enforcement_alert_component.rb
index fd62a15825a3..4e1e38960d9c 100644
--- a/ee/app/components/namespaces/storage/pre_enforcement_alert_component.rb
+++ b/ee/app/components/namespaces/storage/pre_enforcement_alert_component.rb
@@ -15,6 +15,7 @@ def initialize(context:, user:)
       end
 
       def render?
+        return true
         return false unless user_allowed?
         return false if qualifies_for_combined_alert?
         return false unless over_storage_limit?(root_namespace)
  • Navigate to a group page where you have maintainer+ role
  • Observe the banners at the top and the docs links in each

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #432317

Edited by Ammar Alakkad

Merge request reports