Skip to content

Remove a few elements from the legacy header layout

Lukas 'ai-pi' Eipert requested to merge leipert-remove-more-header-bar-layout into master

What does this MR do and why?

Remove a few elements from the legacy header layout

The legacy nav isn't used any more, so we can chip away on the header layout elements. All of the following have no associated helpers / CSS that can be removed.

This removes:

  • Sign Up / Sign in buttons
  • Set User Status Modal entry point

Remove legacy impersonation code

This removes legacy impersonation code and related CSS.

Remove old user dropdown and related code

This removes the legacy user dropdown and related code. It isn't needed any longer, as the legacy nav cannot be used anymore.

Remove user counts from legacy nav

Removing the counts and related helpers from the legacy nav.

Remove assigned_mrs_dashboard_path helper

This helper was unused, apart from a single spec. By adjusting the spec we can get rid of this helper as well.

Screenshots or screen recordings

N/A - No user visible change

How to set up and validate locally

  1. Navigate through a few pages and see that everything works.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas 'ai-pi' Eipert

Merge request reports