Skip to content

Simplify helpers around collapsed sidebar state

Lukas 'ai-pi' Eipert requested to merge leipert-remove-collapsed-state into master

What does this MR do and why?

Simplify page_with_sidebar_class helper

As the super sidebar is now always active, we can simplify the page_with_sidebar_class helper quite a bit. It also allows us to remove some other helpers:

  • ApplicationHelper#collapsed_sidebar?
  • NavigationHelper#page_has_collapsed_sidebar?
  • NavigationHelper#page_has_collapsed_super_sidebar?
  • NavigationHelper#page_has_sidebar?

The latter is always true on pages that render the new sidebar, because we actually set it in: app/views/layouts/_page.html.haml if the super sidebar is enabled.

Remove global variable left_sidebar

All the places which use this variable have been removed, rendering it obsolete. We can just remove it.

Screenshots or screen recordings

N/A => Behaves the same as before

How to set up and validate locally

  1. Navigate through all the pages

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports