Skip to content

Remove unused code paths from top bar

Lukas 'ai-pi' Eipert requested to merge leipert-remove-left-sidebar-var into master

What does this MR do and why?

Remove outdated no_top_bar_container global var

This variable was used in two places:

  1. top_bar, if the super sidebar is disabled. As it is now always enabled, this usage is obsolete.
  2. auto_devops_callout. This is used via app/views/projects/_flash_messages.html.haml which is only included on the Project overview and Project empty page.

The variable was only set in the pages: Group Epics, Group Roadmap and Issue/Epic Boards. All of these have no overlap with the auto_devops_callout and therefore are safe to remove.

Remove legacy sidebar code paths from top bar

The super sidebar is now always enabled, therefore we can remove the alternate code paths.

Screenshots or screen recordings

The AutoDevOps banner still renders the same way:

Before After
Screenshot_2023-12-05_at_13.24.48 Screenshot_2023-12-05_at_13.45.41

How to set up and validate locally

  1. Check out locally
  2. In app/helpers/auto_devops_helper.rb change show_auto_devops_callout? to return true
  3. Visit any project page

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas 'ai-pi' Eipert

Merge request reports