Remove unused code paths from top bar
What does this MR do and why?
Remove outdated no_top_bar_container global var
This variable was used in two places:
-
top_bar
, if the super sidebar is disabled. As it is now always enabled, this usage is obsolete. -
auto_devops_callout
. This is used viaapp/views/projects/_flash_messages.html.haml
which is only included on the Project overview and Project empty page.
The variable was only set in the pages: Group Epics, Group Roadmap and
Issue/Epic Boards. All of these have no overlap with the
auto_devops_callout
and therefore are safe to remove.
Remove legacy sidebar code paths from top bar
The super sidebar is now always enabled, therefore we can remove the alternate code paths.
Screenshots or screen recordings
The AutoDevOps banner still renders the same way:
Before | After |
---|---|
How to set up and validate locally
- Check out locally
- In
app/helpers/auto_devops_helper.rb
changeshow_auto_devops_callout?
to returntrue
- Visit any project page
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Lukas 'ai-pi' Eipert