Skip to content

Fix non-nullable engineName for code quality degradations

Ahmed Hemdan requested to merge fix-non-nullable-engine-name-for-codequality-degradations into master

What does this MR do and why?

As we started to roll-out sast_reports_in_inline_diff feature flag on gitlab-org/gitlab project, it came to our attention that some codequality degradations does not have an engine_name stored for them, and therefore, they are null. This seems to be the case for degradations in markdown files (see these two merge requests for example: 1, 2).

This merge request updates the field in CodequalityReportsComparer.DegradationType to have null: true so that these reports are rendered correctly and without errors to the users.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports