Skip to content

Fix invalid ci_finished_builds.started_at values

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/433983/fix-ci_finished_builds-started_at-default-value into master

What does this MR do and why?

This MR:

  • fixes ci_finished_builds.started_at default value to use either finished_at or 0 instead of now(), so that NULL started_at values yield records that make sense or are easily distinguishable.
  • updates existing invalid records so that started_at = finished_at, and therefore duration is 0.

EE: true

Closes #433983 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Step SHOW TABLE ci_finished_builds
image. image
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. bundle exec rake gitlab:clickhouse:migrate
  2. bundle exec rake gitlab:clickhouse:rollback STEP=2

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro (OOO from July 16th till Aug 7th)

Merge request reports