Skip to content

Ensure milestone is a string in db/docs/batched_background_migrations

Dylan Griffith requested to merge db-docs-background-migrations-milestone-should-be-string into master

What does this MR do and why?

Ensure milestone is a string in db/docs/batched_background_migrations

Using a number is causing problems for milestones like 15.10 as this gets converted to 15.1 when loaded via YAML. Therefore we must use a string for the milestone. We are already using strings for milestone in the db/docs/*.yml files that correspond to tables.

In particular this caused me problems because I'm trying to write some automation that makes updates to these YAML files and doing YAML.load and YAML.dump was incorrectly updating these values.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports