Replace milestone promotion banner with alert
What does this MR do and why?
- Replace the milestone promotion banner with an alert because there is nothing to promote. For information we use alerts.
- Fix bug when burndown chart was visible with no issues in a milestone.
- Fix bug when "no issues" alert was shown with one issue in a milestone.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
When | Before | After |
---|---|---|
Milestone is ready to be closed | ![]() |
![]() |
No issues, no dates | ![]() |
![]() |
No dates | ![]() |
![]() |
No issues | ![]() |
![]() |
Issues and dates | ![]() |
![]() |
How to set up and validate locally
- Go to any empty milestone, for example
http://gdk.test:3000/gitlab-org/gitlab-shell/-/milestones
- Create a milestone with no dates
- See a 'Add start and due date to view a burndown chart. Assign some issues to this milestone.' alert
- Add dates
- See 'Assign some issues to this milestone.' alert
- Remove dates
- Assign one issue to this milestone
- See 'Add start and due date to view a burndown chart.' alert
- Add dates
- See burndown/burnup charts and no alerts
- Close assigned issue
- Go back to milestone
- See
All issues for this milestone are closed. You may close this milestone now.
alert
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @jmiocene
3 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.This merge request does not refer to an existing milestone. This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/views/projects/milestones/show.html.haml
+ alert_options: { data: { testid: 'all-issues-closed-alert' }}, - data: { testid: 'no-issues-alert' }}) do |c| + data: { testid: 'no-dates-alert' }}) do |c|
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start thetrigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure the tests infollow-up-e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @mc_rocha
(UTC-5, 6 hours behind author)
@dbalexandre
(UTC+0, 1 hour behind author)
frontend @robyrne
(UTC+0, 1 hour behind author)
@jivanvl
(UTC-6, 7 hours behind author)
test for spec/features/*
@mc_rocha
(UTC-5, 6 hours behind author)
Maintainer review is optional for test for spec/features/*
UX @afracazo
(UTC+11, 10 hours ahead of author)
Maintainer review is optional for UX Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@jmiocene - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 381e4bd1 and 1574984d
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.1 MB 4.1 MB - -0.0 % mainChunk 3.04 MB 3.04 MB - 0.0 %
Note: We do not have exact data for 381e4bd1. So we have used data from: 53eb7c86.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded UX UX Paper Cuts groupux paper cuts typemaintenance labels
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1574984dexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Create | 52 | 0 | 9 | 0 | 61 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 226 | 0 | 12 | 0 | 238 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added Technical Writing label
added 1 commit
- b6ba9497 - Replace milestone promotion banner with alert
added 1 commit
- c9330cc0 - Replace milestone promotion banner with alert
mentioned in merge request !138067 (merged)
added 1 commit
- f77c840a - Replace milestone promotion banner with alert
added 1 commit
- 1574984d - Replace milestone promotion banner with alert
added 1 commit
- db47c74a - Replace milestone promotion banner with alert
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/views/projects/milestones/show.html.haml
- data: { testid: 'no-issues-alert' }}) do |c| + alert_options: { data: { testid: 'all-issues-closed-alert' }},
ee/app/views/shared/milestones/_burndown.html.haml
+ data: { testid: 'no-issues-and-dates-alert' }}) do |c|
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start thetrigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure the tests infollow-up-e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer backend @eduardobonet
(UTC+1, same timezone as author)
@brytannia
(UTC+1, same timezone as author)
frontend @nradina
(UTC+1, same timezone as author)
@elwyn-gitlab
(UTC+13, 12 hours ahead of author)
test for spec/features/*
@eduardobonet
(UTC+1, same timezone as author)
Maintainer review is optional for test for spec/features/*
UX @katiemacoy
(UTC+13, 12 hours ahead of author)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 8e6bb52e and c323a81e
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.22 MB 4.22 MB - 0.0 % mainChunk 3.22 MB 3.22 MB - 0.0 %
Note: We do not have exact data for 8e6bb52e. So we have used data from: c3e3cb78.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- fd6c0119 - Replace milestone promotion banner with alert
- Resolved by Vasilii Iakliushin
added 1 commit
- 0c03c069 - Replace milestone promotion banner with alert
- Resolved by Vasilii Iakliushin
- Resolved by Vasilii Iakliushin
mentioned in merge request !143992 (merged)
added 9843 commits
-
0c03c069...cec23155 - 9842 commits from branch
master
- 1a715cb8 - Replace milestone promotion banner with alert
-
0c03c069...cec23155 - 9842 commits from branch
added 639 commits
-
1a715cb8...d378ef51 - 638 commits from branch
master
- ffec0a77 - Merge branch 'master' into 'replace-milestone-banner-with-alert'
-
1a715cb8...d378ef51 - 638 commits from branch
- Resolved by Vasilii Iakliushin
changed milestone to %16.10
- Resolved by Julia Miocene
Hey @seggenberger
Could you please review UX?
requested review from @seggenberger
- Resolved by Julia Miocene
@jmiocene thought/question: should we use a button instead of the inline links?
That would make it a bit more actionable and it would also be compliant with the banner component, see https://design.gitlab.com/components/banner#structure
added UI text label
@jmiocene This looks good from a tech writing perspective. The only tiny tweak I might make, non-blocking, would be to add an
a
in this phrase, and potentially repeat the worddate
. I think it might make it slightly better for translation:Add a start date and due date to ...
But otherwise looks good! I'll approve so no need to send back unless you have questions. Thanks.
- Resolved by Vasilii Iakliushin
@sselhorn
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
- Resolved by Julia Miocene
removed review request for @seggenberger