Skip to content

Replace milestone promotion banner with alert

Julia Miocene requested to merge replace-milestone-banner-with-alert into master

What does this MR do and why?

  • Replace the milestone promotion banner with an alert because there is nothing to promote. For information we use alerts.
  • Fix bug when burndown chart was visible with no issues in a milestone.
  • Fix bug when "no issues" alert was shown with one issue in a milestone.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

When Before After
Milestone is ready to be closed 1_before CleanShot_2024-02-08_at_00.46.56_2x
No issues, no dates 2_before 2_after
No dates 3_before 3_after
No issues 4_before 4_after
Issues and dates 5_before 5_after

How to set up and validate locally

  • Go to any empty milestone, for example http://gdk.test:3000/gitlab-org/gitlab-shell/-/milestones
  • Create a milestone with no dates
  • See a 'Add start and due date to view a burndown chart. Assign some issues to this milestone.' alert
  • Add dates
  • See 'Assign some issues to this milestone.' alert
  • Remove dates
  • Assign one issue to this milestone
  • See 'Add start and due date to view a burndown chart.' alert
  • Add dates
  • See burndown/burnup charts and no alerts
  • Close assigned issue
  • Go back to milestone
  • See All issues for this milestone are closed. You may close this milestone now. alert

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

#424397 (closed)

Edited by Julia Miocene

Merge request reports