Skip to content
Snippets Groups Projects

Replace milestone promotion banner with alert

Merged Julia Miocene requested to merge replace-milestone-banner-with-alert into master

What does this MR do and why?

  • Replace the milestone promotion banner with an alert because there is nothing to promote. For information we use alerts.
  • Fix bug when burndown chart was visible with no issues in a milestone.
  • Fix bug when "no issues" alert was shown with one issue in a milestone.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

When Before After
Milestone is ready to be closed 1_before CleanShot_2024-02-08_at_00.46.56_2x
No issues, no dates 2_before 2_after
No dates 3_before 3_after
No issues 4_before 4_after
Issues and dates 5_before 5_after

How to set up and validate locally

  • Go to any empty milestone, for example http://gdk.test:3000/gitlab-org/gitlab-shell/-/milestones
  • Create a milestone with no dates
  • See a 'Add start and due date to view a burndown chart. Assign some issues to this milestone.' alert
  • Add dates
  • See 'Assign some issues to this milestone.' alert
  • Remove dates
  • Assign one issue to this milestone
  • See 'Add start and due date to view a burndown chart.' alert
  • Add dates
  • See burndown/burnup charts and no alerts
  • Close assigned issue
  • Go back to milestone
  • See All issues for this milestone are closed. You may close this milestone now. alert

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

#424397 (closed)

Edited by Julia Miocene

Merge request reports

Merged results pipeline #1202927730 passed

Pipeline: GitLab

#1202958218

    Pipeline: Ruby 3.1 as-if-foss pipeline

    #1202934132

      Pipeline: GitLab

      #1202939262

        +1

        Merged results pipeline passed for 5788aad7

        Test coverage 81.54% (16.56%) from 2 jobs

        Merged by Vasilii IakliushinVasilii Iakliushin 11 months ago (Mar 6, 2024 11:54am UTC)

        Merge details

        • Changes merged into master with 3b4805ab (commits were squashed).
        • Deleted the source branch.
        • Auto-merge enabled

        Pipeline #1203058488 passed

        Pipeline passed for 3b4805ab on master

        Test coverage 64.89% (16.56%) from 2 jobs
        6 environments impacted.

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
        • assigned to @jmiocene

        • A deleted user added backend frontend labels

          added backend frontend labels

        • Contributor
          3 Warnings
          :warning: This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.
          :warning: This merge request does not refer to an existing milestone.
          :warning: This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.

          testid selectors

          The following changed lines in this MR contain testid selectors:

          app/views/projects/milestones/show.html.haml

          +    alert_options: { data: { testid: 'all-issues-closed-alert' }},
          -                                                        data: { testid: 'no-issues-alert' }}) do |c|
          +    data: { testid: 'no-dates-alert' }}) do |c|

          If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure the tests in follow-up-e2e:package-and-test-ee pipeline are passing.

          For the list of known failures please refer to the latest pipeline triage issue.

          If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

          Reviewer roulette

          Changes that require review have been detected!

          Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

          Category Reviewer Maintainer
          backend @mc_rocha profile link current availability (UTC-5, 6 hours behind author) @dbalexandre profile link current availability (UTC+0, 1 hour behind author)
          frontend @robyrne profile link current availability (UTC+0, 1 hour behind author) @jivanvl profile link current availability (UTC-6, 7 hours behind author)
          test for spec/features/* @mc_rocha profile link current availability (UTC-5, 6 hours behind author) Maintainer review is optional for test for spec/features/*
          UX @afracazo profile link current availability (UTC+11, 10 hours ahead of author) Maintainer review is optional for UX

          Please check reviewer's status!

          • available Reviewer is available!
          • unavailable Reviewer is unavailable!

          Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

          To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

          Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

          If needed, you can retry the :repeat: danger-review job that generated this comment.

          Generated by :no_entry_sign: Danger

        • Contributor

          Bundle size analysis [beta]

          This compares changes in bundle size for entry points between the commits 381e4bd1 and 1574984d

          :sparkles: Special assets

          Entrypoint / Name Size before Size after Diff Diff in percent
          average 4.1 MB 4.1 MB - -0.0 %
          mainChunk 3.04 MB 3.04 MB - 0.0 %

          Note: We do not have exact data for 381e4bd1. So we have used data from: 53eb7c86.
          The intended commit has no webpack pipeline, so we chose the last commit with one before it.

          Please look at the full report for more details


          Read more about how this report works.

          Generated by :no_entry_sign: Danger

        • 🤖 GitLab Bot 🤖 resolved all threads

          resolved all threads

        • Contributor

          Allure report

          allure-report-publisher generated test report!

          e2e-test-on-gdk: :white_check_mark: test report for 1574984d

          expand test summary
          +-----------------------------------------------------------------------+
          |                            suites summary                             |
          +------------------+--------+--------+---------+-------+-------+--------+
          |                  | passed | failed | skipped | flaky | total | result |
          +------------------+--------+--------+---------+-------+-------+--------+
          | Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
          | Create           | 52     | 0      | 9       | 0     | 61    | ✅     |
          | Data Stores      | 23     | 0      | 0       | 0     | 23    | ✅     |
          | Govern           | 57     | 0      | 0       | 0     | 57    | ✅     |
          | Verify           | 31     | 0      | 0       | 0     | 31    | ✅     |
          | Monitor          | 8      | 0      | 0       | 0     | 8     | ✅     |
          | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
          | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
          | Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
          +------------------+--------+--------+---------+-------+-------+--------+
          | Total            | 226    | 0      | 12      | 0     | 238   | ✅     |
          +------------------+--------+--------+---------+-------+-------+--------+
        • Julia Miocene changed the description

          changed the description

        • Julia Miocene added 1 commit

          added 1 commit

          • b6ba9497 - Replace milestone promotion banner with alert

          Compare with previous version

        • Julia Miocene added 1 commit

          added 1 commit

          • c9330cc0 - Replace milestone promotion banner with alert

          Compare with previous version

        • Julia Miocene changed the description

          changed the description

        • Julia Miocene mentioned in merge request !138067 (merged)

          mentioned in merge request !138067 (merged)

        • Julia Miocene added 1 commit

          added 1 commit

          • f77c840a - Replace milestone promotion banner with alert

          Compare with previous version

        • Julia Miocene changed the description

          changed the description

        • Julia Miocene added 1 commit

          added 1 commit

          • 1574984d - Replace milestone promotion banner with alert

          Compare with previous version

        • Julia Miocene added 1 commit

          added 1 commit

          • db47c74a - Replace milestone promotion banner with alert

          Compare with previous version

        • Contributor
          2 Warnings
          :warning: This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.
          :warning: This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.

          testid selectors

          The following changed lines in this MR contain testid selectors:

          app/views/projects/milestones/show.html.haml

          -                                                        data: { testid: 'no-issues-alert' }}) do |c|
          +    alert_options: { data: { testid: 'all-issues-closed-alert' }},

          ee/app/views/shared/milestones/_burndown.html.haml

          +    data: { testid: 'no-issues-and-dates-alert' }}) do |c|

          If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure the tests in follow-up-e2e:package-and-test-ee pipeline are passing.

          For the list of known failures please refer to the latest pipeline triage issue.

          If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

          Reviewer roulette

          Category Reviewer Maintainer
          backend @eduardobonet profile link current availability (UTC+1, same timezone as author) @brytannia profile link current availability (UTC+1, same timezone as author)
          frontend @nradina profile link current availability (UTC+1, same timezone as author) @elwyn-gitlab profile link current availability (UTC+13, 12 hours ahead of author)
          test for spec/features/* @eduardobonet profile link current availability (UTC+1, same timezone as author) Maintainer review is optional for test for spec/features/*
          UX @katiemacoy profile link current availability (UTC+13, 12 hours ahead of author) Maintainer review is optional for UX

          Please check reviewer's status!

          • available Reviewer is available!
          • unavailable Reviewer is unavailable!

          Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

          If needed, you can retry the :repeat: danger-review job that generated this comment.

          Generated by :no_entry_sign: Danger

        • Contributor

          Bundle size analysis [beta]

          This compares changes in bundle size for entry points between the commits 8e6bb52e and c323a81e

          :sparkles: Special assets

          Entrypoint / Name Size before Size after Diff Diff in percent
          average 4.22 MB 4.22 MB - 0.0 %
          mainChunk 3.22 MB 3.22 MB - 0.0 %

          Note: We do not have exact data for 8e6bb52e. So we have used data from: c3e3cb78.
          The intended commit has no webpack pipeline, so we chose the last commit with one before it.

          Please look at the full report for more details


          Read more about how this report works.

          Generated by :no_entry_sign: Danger

        • Julia Miocene added 1 commit

          added 1 commit

          • fd6c0119 - Replace milestone promotion banner with alert

          Compare with previous version

        • Julia Miocene changed the description

          changed the description

        • Ghost User
      • Julia Miocene added 1 commit

        added 1 commit

        • 0c03c069 - Replace milestone promotion banner with alert

        Compare with previous version

      • Ghost User
      • Ghost User
      • Julia Miocene mentioned in merge request !143992 (merged)

        mentioned in merge request !143992 (merged)

      • Julia Miocene changed the description

        changed the description

      • Julia Miocene added 9843 commits

        added 9843 commits

        Compare with previous version

      • Julia Miocene added 639 commits

        added 639 commits

        Compare with previous version

      • Julia Miocene added 1 commit

        added 1 commit

        Compare with previous version

      • Julia Miocene changed the description

        changed the description

      • Julia Miocene added 1 commit

        added 1 commit

        Compare with previous version

      • Julia Miocene added 1 commit

        added 1 commit

        Compare with previous version

      • Ghost User
      • Julia Miocene changed milestone to %16.10

        changed milestone to %16.10

      • Julia Miocene changed the description

        changed the description

      • Julia Miocene requested review from @seggenberger

        requested review from @seggenberger

      • added UI text label

      • @jmiocene This looks good from a tech writing perspective. The only tiny tweak I might make, non-blocking, would be to add an a in this phrase, and potentially repeat the word date. I think it might make it slightly better for translation:

        Add a start date and due date to ...

        But otherwise looks good! I'll approve so no need to send back unless you have questions. Thanks.

      • Suzanne Selhorn approved this merge request

        approved this merge request

      • Julia Miocene marked this merge request as ready

        marked this merge request as ready

      • Sascha Eggenberger approved this merge request

        approved this merge request

      • Sascha Eggenberger removed review request for @seggenberger

        removed review request for @seggenberger

      • Julia Miocene added 1 commit

        added 1 commit

        Compare with previous version

      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Please register or sign in to reply
        Loading