Skip to content

Updates reviews to include the state of the review

Phil Hughes requested to merge ph/reviewState into master

What does this MR do and why?

This changes the state that gets set on reviewers to be set on the review instead. This means that when you submit a review the action that the user chooses will be set on the review object instead of the reviewer. When the user gets assigned later their status will reflect the state of the last review the submitted.

Migrate up

main: == [advisory_lock_connection] object_id: 183940, pg_backend_pid: 25998
main: == 20231201111622 AddStateToReview: migrating =================================
main: -- add_column(:reviews, :state, :smallint, {:default=>0, :null=>false})
main:    -> 0.0051s
main: == 20231201111622 AddStateToReview: migrated (0.0109s) ========================

main: == [advisory_lock_connection] object_id: 183940, pg_backend_pid: 25998

Migration down

main: == [advisory_lock_connection] object_id: 182960, pg_backend_pid: 25341
main: == 20231201111622 AddStateToReview: reverting =================================
main: -- remove_column(:reviews, :state, :smallint, {:default=>0, :null=>false})
main:    -> 0.0017s
main: == 20231201111622 AddStateToReview: reverted (0.0077s) ========================

main: == [advisory_lock_connection] object_id: 182960, pg_backend_pid: 25341

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Phil Hughes

Merge request reports