Skip to content

Remove legacy sidebar partials

Thomas Hutterer requested to merge thutterer/rm-legacy-sidebar-haml into master

What does this MR do and why?

This MR is part of the Remove the old navigation code (&11875) epic.

It removes two folders of partials for the different sidebars we had (Project, group etc.) and their partials. It looks a bit big in number of files and lines removed, but it's really just these two folders and their view specs 😇

In follow-ups we will remove the styles and helpers used in these partials. We are keeping a list of tracked classes in https://docs.google.com/spreadsheets/d/1L0KRA5eLRUBayn_TTuEkJQTFfxYmUX8DYlwOjsf3PAE/edit?usp=sharing.

Screenshots or screen recordings

No visual change for the current ("super sidebar") nav, which is rendered with Vue. These Haml partials were only used by the now disabled old nav.

How to set up and validate locally

  • Make sure CI is passing.
  • Sign out of your GDK and make sure the layout for guest users renders fine. This is the only manual test I could think of. This "guest layout" still uses some CSS of the old nav for its topbar. But its sidebar is Vue.js already, so there shouldn't be any side effects, but please double-check.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thomas Hutterer

Merge request reports