Skip to content

Fix storage banner inconsistent width

Ammar Alakkad requested to merge 371335-fix-banner-inconsistency into master

What does this MR do and why?

It fixes the storage banner inconsistency where in fixed layout it was rendered narrower than the rest of the content.

Screenshots or screen recordings

Layout width Before After
fixed Screenshot_2023-11-30_at_13.53.10 Screenshot_2023-11-30_at_13.45.45
fluid (no visual change) Screenshot_2023-11-30_at_13.53.31 Screenshot_2023-11-30_at_13.55.27

How to set up and validate locally

  1. Update render? method in ee/app/components/namespaces/storage/limit_alert_component.rb to return true
  2. Navigate to a project, group or user preferences page
  3. Observe the storage banner width

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #371335

Edited by Ammar Alakkad

Merge request reports