Update error to show in correct place
What does this MR do and why?
Update error to show in correct place
- move branches errors to top of the page
- rename components
- update tests
EE: true
Changelog: changed
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Scenario | Screenshot |
|---|---|
| Approvals error - rule mode |  |
| Approvals error - yaml mode |  |
| Branches error - rule mode |  |
| Branches error - yaml mode |  |
| Errors | Screenshot |
|---|---|
| Approvals error |  |
| Branches error |  |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Upload a GitLab Ultimate license
- Navigate to a project/group => Secure => Policies => New policy => Scan Result Policy
- Create a policy with no protected branches selected (e.g. select all protected branches as exceptions)
- Attempt to save the policy
- Verify the error is at the top of the page
- Create a policy with valid branches selected and no approvers selected
- Verify the error is by the approvals section
- Switch to yaml mode
- Verify the error is always at the top
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #430943 (closed)