Skip to content

Disable STI checks on production

Peter Leitzen requested to merge pl-disables-sti-production into master

What does this MR do and why?

This MR disables STI checks on production as suggested in !136649 (comment 1672125213).

$ RAILS_ENV=production bin/rails  console
--------------------------------------------------------------------------------
 Ruby:         ruby 3.1.4p223 (2023-03-30 revision 957bb7cb81) [x86_64-linux]
 GitLab:       16.7.0-pre (9a53620612f) EE
 GitLab Shell: 14.30.1
 PostgreSQL:   14.9
------------------------------------------------------------[ booted in 28.85s ]
Loading production environment (Rails 7.0.8)
>> DisablesSti::SKIP_STI_CHECK
=> true

$ bin/rails  console
--------------------------------------------------------------------------------
 Ruby:         ruby 3.1.4p223 (2023-03-30 revision 957bb7cb81) [x86_64-linux]
 GitLab:       16.7.0-pre (2d115b3c818) EE
 GitLab Shell: 14.30.1
 PostgreSQL:   14.9
-------------------------------------------------------------[ booted in 6.34s ]
Loading development environment (Rails 7.0.8)
[1] pry(main)> DisablesSti::SKIP_STI_CHECK
=> false

$ SKIP_STI_CHECK=1 bin/rails  console
--------------------------------------------------------------------------------
 Ruby:         ruby 3.1.4p223 (2023-03-30 revision 957bb7cb81) [x86_64-linux]
 GitLab:       16.7.0-pre (2d115b3c818) EE
 GitLab Shell: 14.30.1
 PostgreSQL:   14.9
-------------------------------------------------------------[ booted in 6.42s ]
Loading development environment (Rails 7.0.8)
[1] pry(main)> DisablesSti::SKIP_STI_CHECK
=> true

$ RAILS_ENV=production SKIP_STI_CHECK=1 bin/rails  console

--------------------------------------------------------------------------------
 Ruby:         ruby 3.1.4p223 (2023-03-30 revision 957bb7cb81) [x86_64-linux]
 GitLab:       16.7.0-pre (2d115b3c818) EE
 GitLab Shell: 14.30.1
 PostgreSQL:   14.9
------------------------------------------------------------[ booted in 25.91s ]
Loading production environment (Rails 7.0.8)
>> DisablesSti::SKIP_STI_CHECK
=> true

It is false on current master (and production).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports