Skip to content

Remove class in metric definitions for internal events

Niko Belokolodov requested to merge 429454-get-rid-of-instrumentation_class-in-metric-definitions-for-internal-events into master

What does this MR do and why?

Currently, metric definitions for metrics that use the data_source: internal_events need to provide an instrumentation_class.

For metrics that are total counts this is TotalCountMetric and for unique counts this is RedisHLLMetric.

Following the above, we can remove this duplicate information and figure out necessary class from data_source

This MR also need to update all the affected metrics, thats why so many definitions are affected.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #429454 (closed)

Edited by Niko Belokolodov

Merge request reports