Backport "Revert "Merge branch 'sc1-release-goredis' into 'master'""
What does this MR do and why?
This MR reverts the go-redis release to use redigo as it properly supports TLS for SM-users. The TLS support gets added in !138010 (merged).
Originating issue: omnibus-gitlab#8329 (comment 1670764656)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. -
The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes). -
This MR has a severity label assigned (if applicable). -
Set the milestone of the merge request to match the target backport branch version. -
This MR has been approved by a maintainer (only one approval is required). -
Ensure the e2e:package-and-test-ee
job has either succeeded or been approved by a Software Engineer in Test.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releases
Slack channel (internal only).
Merge request reports
Activity
added groupscalability workhorse labels
assigned to @schin1
To speed up your revert merge request, please consider using the revert merge request template. Adding the appropriate labels for resolving master:broken before the merge request is created will skip several CI/CD jobs.
For this merge request, if this is for resolving master:broken you can add the appropriate labels present in the merge request template, and trigger a new pipeline. It will be faster
.added devopsplatforms sectionplatforms labels
mentioned in issue Taucher2003/reporting#238 (closed)
added bugfunctional label
added typebug label
added redis label
changed milestone to %16.6
added 30 commits
-
622b0195...1e2739f4 - 29 commits from branch
16-6-stable-ee
- 03d382c3 - Revert "Merge branch 'sc1-release-goredis' into 'master'"
-
622b0195...1e2739f4 - 29 commits from branch
added 30 commits
-
622b0195...1e2739f4 - 29 commits from branch
16-6-stable-ee
- 03d382c3 - Revert "Merge branch 'sc1-release-goredis' into 'master'"
-
622b0195...1e2739f4 - 29 commits from branch
added 30 commits
-
622b0195...1e2739f4 - 29 commits from branch
16-6-stable-ee
- 03d382c3 - Revert "Merge branch 'sc1-release-goredis' into 'master'"
-
622b0195...1e2739f4 - 29 commits from branch
added Pick into 16.0 label
1 Warning The e2e:package-and-test-ee
job needs to succeed or have approval from a Software Engineer in Test.
Read the "QA e2e:package-and-test-ee" section for more details.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer workhorse No reviewer available No maintainer available Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
QA
e2e:package-and-test-ee
@schin1, the
package-and-test
job must complete before merging this merge request.*If there are failures on the
package-and-test
pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the#quality
Slack channel.If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- 9589d802 - Revert "Merge branch 'sc1-release-goredis' into 'master'"
@stanhu Could I get your review for this? I'm following the steps in https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/patch/engineers.md#process-to-create-a-backport-merge-request
The original pipeline failures were due to gitlab-com/gl-infra/production#17185 (closed).
requested review from @stanhu
mentioned in issue omnibus-gitlab#8329 (closed)
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 9589d802expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 40 | 0 | 7 | 0 | 47 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 201 | 0 | 10 | 0 | 211 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 9589d802expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 152 | 0 | 25 | 0 | 177 | ✅ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 31 | 0 | 2 | 0 | 33 | ✅ | | Package | 25 | 0 | 2 | 0 | 27 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 9 | 0 | 1 | 0 | 10 | ✅ | | Analytics | 1 | 0 | 0 | 0 | 1 | ✅ | | Manage | 31 | 0 | 4 | 11 | 35 | ❗ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 12 | 0 | 1 | 0 | 13 | ✅ | | Data Stores | 15 | 2 | 1 | 1 | 18 | ❌ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 289 | 2 | 39 | 12 | 330 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Stan Hu
@stanhu
, thanks for approving this merge request.This is the first time the merge request has been approved. Please ensure the
e2e:package-and-test-ee
job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the#quality
Slack channel.
enabled an automatic merge when the pipeline for f99ee937 succeeds
- Resolved by Sylvester Chin
@schin1 Thee2e:package-and-test-ee
job has failed.-
e2e:package-and-test-ee
pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/1088717459
e2e:package-and-test-ee
pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the
#quality
Slack channel. -
mentioned in commit 8446e573
mentioned in issue gitlab-org/release/tasks#7521 (closed)
mentioned in merge request !137842 (merged)