Skip to content

Hide product analytics settings when disabled

Halil Coban requested to merge hide-pa-settings-if-disabled into master

What does this MR do and why?

When the Product Analytics toggle in off, product analytics settings form should be hidden. This MR implements this.

This is the last part of #414865 (closed)

The commit doesn't have a changelog entry as it's behind the feature flag product_analytics_dashboards

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After (product analytics enabled) After (product analytics disabled)
Screenshot_2023-11-28_at_14.31.15 Screenshot_2023-11-28_at_14.31.15 Screenshot_2023-11-28_at_14.31.31

How to set up and validate locally

  1. Make sure to have a project with product analytics dashboards
  2. In the project page sidebar, click Settings -> Analytics
  3. You should be able to see the project analytics settings form under "Data sources"
  4. Visit group settings page in the root namespace
  5. Under "Permissions and group features" -> Uncheck "Use product analytics" checkbox
  6. Go back to project page
  7. In the project page sidebar, click Settings -> Analytics
  8. You should not anymore see the project analytics settings form under "Data sources"

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Halil Coban

Merge request reports