Skip to content

test_file_finder: Map controllers to requests specs

Peter Leitzen requested to merge pl-tff-map-controllers-to-requests into master

What does this MR do and why?

This MR add mappings for controllers to map request specs.

Contributes to #432986.

After this MR 129 more controller files can be mapped to requests specs:

Diff
--- before	2023-11-28 12:34:10.144177925 +0100
+++ after	2023-11-28 12:34:34.917705722 +0100
@@ -2,23 +2,13 @@
 app/channels/application_cable/logging.rb
 app/channels/graphql_channel.rb
 app/components/diffs/base_component.rb
-app/controllers/abuse_reports_controller.rb
 app/controllers/activity_pub/application_controller.rb
 app/controllers/activity_pub/projects/application_controller.rb
-app/controllers/admin/abuse_reports_controller.rb
 app/controllers/admin/application_controller.rb
 app/controllers/admin/background_jobs_controller.rb
-app/controllers/admin/background_migrations_controller.rb
-app/controllers/admin/batched_jobs_controller.rb
-app/controllers/admin/broadcast_messages_controller.rb
-app/controllers/admin/clusters/integrations_controller.rb
 app/controllers/admin/deploy_keys_controller.rb
-app/controllers/admin/hook_logs_controller.rb
-app/controllers/admin/impersonation_tokens_controller.rb
 app/controllers/admin/keys_controller.rb
 app/controllers/admin/system_info_controller.rb
-app/controllers/admin/version_check_controller.rb
-app/controllers/clusters/agents/dashboard_controller.rb
 app/controllers/clusters/base_controller.rb
 app/controllers/clusters/clusters_controller.rb
 app/controllers/clusters/integrations_controller.rb
@@ -64,7 +54,6 @@
 app/controllers/concerns/packages_access.rb
 app/controllers/concerns/paginated_collection.rb
 app/controllers/concerns/params_backward_compatibility.rb
-app/controllers/concerns/planning_hierarchy.rb
 app/controllers/concerns/preview_markdown.rb
 app/controllers/concerns/project_stats_refresh_conflicts_guard.rb
 app/controllers/concerns/record_user_last_activity.rb
@@ -108,111 +97,46 @@
 app/controllers/concerns/workhorse_request.rb
 app/controllers/dashboard/application_controller.rb
 app/controllers/explore/application_controller.rb
-app/controllers/explore/catalog_controller.rb
-app/controllers/external_redirect/external_redirect_controller.rb
-app/controllers/groups/achievements_controller.rb
 app/controllers/groups/autocomplete_sources_controller.rb
-app/controllers/groups/clusters/integrations_controller.rb
-app/controllers/groups/crm/contacts_controller.rb
-app/controllers/groups/crm/organizations_controller.rb
-app/controllers/groups/custom_emoji_controller.rb
 app/controllers/groups/dependency_proxy/application_controller.rb
-app/controllers/groups/deploy_tokens_controller.rb
 app/controllers/groups/harbor/application_controller.rb
-app/controllers/groups/harbor/artifacts_controller.rb
-app/controllers/groups/harbor/repositories_controller.rb
-app/controllers/groups/harbor/tags_controller.rb
-app/controllers/groups/settings/access_tokens_controller.rb
 app/controllers/groups/settings/packages_and_registries_controller.rb
-app/controllers/groups/usage_quotas_controller.rb
-app/controllers/groups/work_items_controller.rb
-app/controllers/health_controller.rb
-app/controllers/ide_controller.rb
 app/controllers/import/base_controller.rb
-app/controllers/import/github_groups_controller.rb
-app/controllers/import/gitlab_groups_controller.rb
-app/controllers/import/gitlab_projects_controller.rb
 app/controllers/import/history_controller.rb
-app/controllers/import/url_controller.rb
 app/controllers/jira_connect/application_controller.rb
-app/controllers/jira_connect/installations_controller.rb
-app/controllers/jira_connect/oauth_application_ids_controller.rb
-app/controllers/jira_connect/oauth_callbacks_controller.rb
-app/controllers/jira_connect/public_keys_controller.rb
-app/controllers/jwks_controller.rb
-app/controllers/jwt_controller.rb
-app/controllers/mailgun/webhooks_controller.rb
 app/controllers/organizations/application_controller.rb
-app/controllers/organizations/organizations_controller.rb
-app/controllers/organizations/settings_controller.rb
 app/controllers/profiles/application_controller.rb
 app/controllers/profiles/chat_names_controller.rb
-app/controllers/profiles/comment_templates_controller.rb
 app/controllers/profiles/groups_controller.rb
 app/controllers/profiles/passwords_controller.rb
-app/controllers/projects/alert_management_controller.rb
 app/controllers/projects/application_controller.rb
 app/controllers/projects/aws/base_controller.rb
-app/controllers/projects/aws/configuration_controller.rb
 app/controllers/projects/build_artifacts_controller.rb
 app/controllers/projects/builds_controller.rb
 app/controllers/projects/ci/prometheus_metrics/histograms_controller.rb
-app/controllers/projects/cluster_agents_controller.rb
-app/controllers/projects/clusters/integrations_controller.rb
 app/controllers/projects/confluences_controller.rb
 app/controllers/projects/deploy_tokens_controller.rb
 app/controllers/projects/design_management/designs_controller.rb
 app/controllers/projects/error_tracking/base_controller.rb
 app/controllers/projects/google_cloud/base_controller.rb
-app/controllers/projects/google_cloud/configuration_controller.rb
-app/controllers/projects/google_cloud/databases_controller.rb
-app/controllers/projects/google_cloud/deployments_controller.rb
-app/controllers/projects/google_cloud/gcp_regions_controller.rb
-app/controllers/projects/google_cloud/revoke_oauth_controller.rb
-app/controllers/projects/google_cloud/service_accounts_controller.rb
 app/controllers/projects/harbor/application_controller.rb
-app/controllers/projects/harbor/artifacts_controller.rb
-app/controllers/projects/harbor/repositories_controller.rb
-app/controllers/projects/harbor/tags_controller.rb
-app/controllers/projects/hook_logs_controller.rb
 app/controllers/projects/incident_management/pager_duty_incidents_controller.rb
 app/controllers/projects/incident_management/timeline_events_controller.rb
-app/controllers/projects/incidents_controller.rb
 app/controllers/projects/merge_requests/application_controller.rb
-app/controllers/projects/ml/candidates_controller.rb
-app/controllers/projects/ml/experiments_controller.rb
-app/controllers/projects/ml/model_versions_controller.rb
-app/controllers/projects/ml/models_controller.rb
-app/controllers/projects/network_controller.rb
-app/controllers/projects/packages/package_files_controller.rb
 app/controllers/projects/pipelines/application_controller.rb
 app/controllers/projects/protected_refs_controller.rb
-app/controllers/projects/redirect_controller.rb
 app/controllers/projects/registry/application_controller.rb
-app/controllers/projects/service_desk/custom_email_controller.rb
-app/controllers/projects/service_desk_controller.rb
-app/controllers/projects/settings/access_tokens_controller.rb
 app/controllers/projects/settings/branch_rules_controller.rb
-app/controllers/projects/settings/packages_and_registries_controller.rb
 app/controllers/projects/snippets/application_controller.rb
 app/controllers/projects/triggers_controller.rb
-app/controllers/pwa_controller.rb
 app/controllers/repositories/application_controller.rb
 app/controllers/repositories/git_http_client_controller.rb
 app/controllers/repositories/lfs_api_controller.rb
 app/controllers/repositories/lfs_locks_api_controller.rb
-app/controllers/runner_setup_controller.rb
-app/controllers/sandbox_controller.rb
 app/controllers/snippets/application_controller.rb
-app/controllers/terraform/services_controller.rb
-app/controllers/time_tracking/timelogs_controller.rb
 app/controllers/users/group_callouts_controller.rb
-app/controllers/users/namespace_visits_controller.rb
 app/controllers/users/pins_controller.rb
 app/controllers/users/project_callouts_controller.rb
-app/controllers/users_controller.rb
-app/controllers/web_ide/remote_ide_controller.rb
-app/controllers/whats_new_controller.rb
 app/events/ci/job_artifacts_deleted_event.rb
 app/events/ci/pipeline_created_event.rb
 app/events/gitlab_subscriptions/renewed_event.rb
@@ -3457,14 +3381,7 @@
 db/seeds.rb
 ee/app/components/namespaces/combined_storage_users/base_alert_component.rb
 ee/app/components/namespaces/free_user_cap/base_alert_component.rb
-ee/app/controllers/admin/application_settings/roles_and_permissions_controller.rb
-ee/app/controllers/admin/application_settings/scim_oauth_controller.rb
-ee/app/controllers/admin/credentials_controller.rb
 ee/app/controllers/admin/geo/application_controller.rb
-ee/app/controllers/admin/geo/replicables_controller.rb
-ee/app/controllers/admin/namespace_limits_controller.rb
-ee/app/controllers/admin/subscriptions_controller.rb
-ee/app/controllers/admin/user_permission_exports_controller.rb
 ee/app/controllers/concerns/admin/license_request.rb
 ee/app/controllers/concerns/arkose/content_security_policy.rb
 ee/app/controllers/concerns/audit_events/date_range.rb
@@ -3499,70 +3416,24 @@
 ee/app/controllers/concerns/registrations_tracking.rb
 ee/app/controllers/concerns/saml_authorization.rb
 ee/app/controllers/concerns/security_dashboards_permissions.rb
-ee/app/controllers/customers_dot/proxy_controller.rb
 ee/app/controllers/ee/admin/application_controller.rb
 ee/app/controllers/ee/clusters/clusters_controller.rb
 ee/app/controllers/ee/groups/autocomplete_sources_controller.rb
 ee/app/controllers/ee/projects/application_controller.rb
 ee/app/controllers/ee/projects/cluster_agents_controller.rb
-ee/app/controllers/ee/projects/deploy_tokens_controller.rb
 ee/app/controllers/ee/projects/incidents_controller.rb
 ee/app/controllers/ee/projects/merge_requests/application_controller.rb
 ee/app/controllers/ee/projects/protected_refs_controller.rb
-ee/app/controllers/ee/projects/service_desk_controller.rb
 ee/app/controllers/ee/repositories/git_http_client_controller.rb
 ee/app/controllers/ee/repositories/lfs_api_controller.rb
 ee/app/controllers/groups/analytics/application_controller.rb
-ee/app/controllers/groups/analytics/cycle_analytics/value_streams_controller.rb
-ee/app/controllers/groups/analytics/dashboards_controller.rb
-ee/app/controllers/groups/analytics/devops_adoption_controller.rb
 ee/app/controllers/groups/bulk_update_controller.rb
-ee/app/controllers/groups/dependencies_controller.rb
-ee/app/controllers/groups/epics/epic_links_controller.rb
-ee/app/controllers/groups/epics/related_epic_links_controller.rb
-ee/app/controllers/groups/hook_logs_controller.rb
 ee/app/controllers/groups/ldap_group_links_controller.rb
-ee/app/controllers/groups/protected_branches_controller.rb
-ee/app/controllers/groups/protected_environments_controller.rb
-ee/app/controllers/groups/secrets_controller.rb
-ee/app/controllers/groups/security/compliance_framework_reports_controller.rb
-ee/app/controllers/groups/security/compliance_violation_reports_controller.rb
-ee/app/controllers/groups/security/credentials_controller.rb
 ee/app/controllers/groups/security/discover_controller.rb
-ee/app/controllers/groups/service_accounts_controller.rb
-ee/app/controllers/groups/settings/domain_verification_controller.rb
-ee/app/controllers/groups/settings/merge_requests_controller.rb
-ee/app/controllers/groups/settings/reporting_controller.rb
-ee/app/controllers/groups/settings/roles_and_permissions_controller.rb
-ee/app/controllers/groups/two_factor_auths_controller.rb
 ee/app/controllers/omniauth_kerberos_controller.rb
-ee/app/controllers/phone_verification/telesign_callbacks_controller.rb
-ee/app/controllers/projects/analytics/code_reviews_controller.rb
-ee/app/controllers/projects/analytics/dashboards_controller.rb
-ee/app/controllers/projects/automations_controller.rb
-ee/app/controllers/projects/ci/catalog/resources_controller.rb
-ee/app/controllers/projects/dependencies_controller.rb
-ee/app/controllers/projects/issue_feature_flags_controller.rb
-ee/app/controllers/projects/metrics_controller.rb
-ee/app/controllers/projects/on_demand_scans_controller.rb
-ee/app/controllers/projects/pipelines/email_campaigns_controller.rb
-ee/app/controllers/projects/secrets_controller.rb
-ee/app/controllers/projects/security/corpus_management_controller.rb
-ee/app/controllers/projects/security/dast_configuration_controller.rb
-ee/app/controllers/projects/security/dast_profiles_controller.rb
-ee/app/controllers/projects/security/dast_scanner_profiles_controller.rb
-ee/app/controllers/projects/security/dast_site_profiles_controller.rb
 ee/app/controllers/projects/security/discover_controller.rb
-ee/app/controllers/projects/security/policies_controller.rb
-ee/app/controllers/projects/settings/analytics_controller.rb
-ee/app/controllers/projects/target_branch_rules_controller.rb
-ee/app/controllers/projects/tracing_controller.rb
 ee/app/controllers/security/application_controller.rb
-ee/app/controllers/smartcard_controller.rb
 ee/app/controllers/subscriptions/hand_raise_leads_controller.rb
-ee/app/controllers/subscriptions/trials_controller.rb
-ee/app/controllers/trial_registrations_controller.rb
-ee/app/controllers/users/identity_verification_controller.rb
 ee/app/enums/security/scan_status_enum.rb
 ee/app/enums/vulnerabilities/dismissal_reason_enum.rb
 ee/app/enums/vulnerabilities/external_type_enum.rb
@@ -5929,4 +5800,4 @@
 tooling/graphql/docs/helper.rb
 tooling/lib/tooling/image.rb
 tooling/merge_request_rspec_failure_rake_task.rb
-{16520=>5931}
+{16520=>5802}

See also #432986.

How to set up and validate locally

bundle exec tff -f tests.yml app/controllers/admin/abuse_reports_controller.rb
bundle exec tff -f tests.yml ee/app/controllers/users_controller.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports