Skip to content

Make milestone mandatory for database dictionary files

Manoj M J requested to merge mmj-make-milestone-mandatory into master

What does this MR do and why?

Why?

Recently, in !135859 (merged), we introduced a check that newly created tables, ie, tables created after milestone 16.7, should not have gitlab_main set as its schema. Naturally, this check depends upon the existence of the milestone attribute being present in the table's database dictionary file (db/docs/table.yml). When this attribute is not present, this check passes by default.

I noticed that a table created after this check was put in place still has gitlab_main as it's schema, and that's because milestone was never mentioned in its db dictionary file. milestone is currently an optional parameter, and this MR makes it mandatory to have milestone attribute for database dictionary files.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Manoj M J

Merge request reports