Skip to content

Update Catalog star icon

Frédéric Caplette requested to merge fc-fix-catalog-star-styles into master

What does this MR do and why?

Star icon should always be star-o regardless of star count.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-11-24_at_10.36.02_AM Screenshot_2023-11-24_at_10.34.00_AM

How to set up and validate locally

  1. Enable the FF global_ci_catalog
  2. Create a few projects that you will be able to convert to Ci resources. Create them under the admin namespace for ease of testing.
  3. Once you have done so, get the ID of the first new project you wanted to convert. Then in Rails console, run:
projects = Project.where("id > ?", your_first_project_id -1)
projects.each do |project|
  project.update!(description: 'description')  
  ::Ci::Catalog::Resource.new(project_id: project.id).save   
end  
  1. Then in the rails console, do Ci::Catalog::Resource.all.each do |r| r.update("state", "published") end
  2. Navigate to Explore -> CI/CD Catalog
  3. Notice that you see Catalog resources
  4. Notice the favorite icon is the bordered one
  5. Go favorite any of these projects
  6. Notice the star is still bordered

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports