Skip to content

Fix an error in QueryRecorder docs

Thong Kuah requested to merge fix_query_record_docs into master

What does this MR do and why?

Fix an error in QueryRecorder docs. Found while working on #432823

To compare with issue_same_number_of_queries_as correctly, we need to ensure both actual and expected both do not skip cached values

The default for ActiveRecord::QueryRecorder.new is skip_cached: true.

The default for issue_same_number_of_queries_as is skip_cached: false.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thong Kuah

Merge request reports