Skip to content

Always save status details for large github import tests

Andrejs Cunskis requested to merge andrey-save-status-always into master

What does this MR do and why?

  • Given import_status is polled continuously during the test, it can simply be stored in an instance variable and referenced at the end of the test. Having default empty value still allows for data json to be saved properly if spec failed before import was even triggered
  • Remove confusing error log. It is better to handle failures explicitly from the test because it is possible to write a test that would expect a failed result for example.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports