Skip to content

Fix bug with pages_deployments files not being deleted on disk

Per Lundberg requested to merge perlun/gitlab:perlun-master-patch-42829 into master

What does this MR do and why?

Fix bug with pages_deployments files not being deleted on disk

This fixes a regression in !132252 (merged). More details in this lengthy writeup: #432689 (closed)

How to set up and validate locally

I have tested this approach manually in the Rails Console towards our environment: #432689 (closed), but obviously some tests for this would be great; particularly to ensure we don't break pages_deployment artifact deletion again. Please fix and add to this MR, if you have the GitLab dev environment already set up (I don't, unfortunately, merely a local GitLab user & admin at this stage. 😃)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • I have evaluated the MR acceptance checklist for this MR.
    • The tests should either be added to this MR or a separate issue created about it.

Merge request reports