Skip to content

Add `rule_type` to indexes explicitly

What does this MR do?

This means that we're enforcing uniqueness of a rule name per approval merge request type on MySQL, since partial indexes are not supported there.

On postgres, rule_type was already part of the index, but as the index is partial it would not apply for rules that are not code owner rules.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11876

Edited by Nick Thomas

Merge request reports

Loading