Skip to content
Snippets Groups Projects

Update rails Banner component

Merged Julia Miocene requested to merge update-banner into master
All threads resolved!

What does this MR do and why?

Change the default Banner background to gray and h1 tag to h2 to match the original component.

Screenshots or screen recordings

before after Pajamas
CleanShot_2023-11-21_at_12.18.57_2x CleanShot_2023-11-21_at_12.18.30_2x CleanShot_2023-11-21_at_12.19.08_2x

How to set up and validate locally

You can check the rails component on Lookbook /rails/lookbook/inspect/pajamas/banner/default and compare it with Pajamas component.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

#430244 (closed)

Edited by Julia Miocene

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rudy Crespo
  • Julia Miocene added 1 commit

    added 1 commit

    • c620eb6a - Update rails Banner component

    Compare with previous version

  • Julia Miocene added 1 commit

    added 1 commit

    • f1bc8cec - Update rails Banner component

    Compare with previous version

  • Sascha Eggenberger approved this merge request

    approved this merge request

  • Sascha Eggenberger removed review request for @seggenberger

    removed review request for @seggenberger

  • Michael Becker approved this merge request

    approved this merge request

  • Michael Becker requested review from @jarka

    requested review from @jarka

  • Jarka Košanová approved this merge request

    approved this merge request

  • Jarka Košanová removed review request for @jarka

    removed review request for @jarka

  • Rudy Crespo approved this merge request

    approved this merge request

  • Rudy Crespo requested review from @jivanvl and removed review request for @rcrespo3

    requested review from @jivanvl and removed review request for @rcrespo3

  • Jose Ivan Vargas approved this merge request

    approved this merge request

  • Jose Ivan Vargas resolved all threads

    resolved all threads

  • Looks good to me!

  • Jose Ivan Vargas enabled an automatic merge when the pipeline for 0d7dce5d succeeds

    enabled an automatic merge when the pipeline for 0d7dce5d succeeds

  • Jose Ivan Vargas mentioned in commit fe65ffad

    mentioned in commit fe65ffad

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading