Update rails Banner component
What does this MR do and why?
Change the default Banner background to gray and h1 tag to h2 to match the original component.
Screenshots or screen recordings
before | after | Pajamas |
---|---|---|
![]() |
![]() |
![]() |
How to set up and validate locally
You can check the rails component on Lookbook /rails/lookbook/inspect/pajamas/banner/default
and compare it with Pajamas component.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.7
added UX UX Paper Cuts groupux paper cuts typemaintenance labels
assigned to @jmiocene
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @hraghuvanshi
(UTC+5.5, 4.5 hours ahead of author)
@sgarg_gitlab
(UTC+5.5, 4.5 hours ahead of author)
frontend @lorenzvanherwaarden
(UTC+1, same timezone as author)
@jivanvl
(UTC-6, 7 hours behind author)
UX @esybrant
(UTC-6, 7 hours behind author)
Maintainer review is optional for UX Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for f1bc8cecexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Create | 40 | 0 | 7 | 0 | 47 | ✅ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 214 | 0 | 10 | 0 | 224 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Julia Miocene
Hey @seggenberger
Could you please review UX?
requested review from @seggenberger
- Resolved by Jose Ivan Vargas
Hey @wandering_person and @rcrespo3
Could you please review backend and frontend and help me with the pipeline error? It's ruby, but about the frontend, so IDK who can help me betterThere is an error
unexpected '!' after 'CHILD_SELECTOR'
, but the CSS class is 'gl-border-none!'. I don't know what options do I have
requested review from @wandering_person and @rcrespo3
- Resolved by Julia Miocene
- Resolved by Julia Miocene
- Resolved by Julia Miocene
- Resolved by Jose Ivan Vargas
@seggenberger
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
removed review request for @seggenberger
mentioned in issue gitlab-com/www-gitlab-com#34689 (closed)
requested review from @jarka
removed review request for @jarka
enabled an automatic merge when the pipeline for 0d7dce5d succeeds
mentioned in commit fe65ffad
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2678 (merged)