Skip to content

Show compact pagination on pipeline security tab

Malcolm Locke requested to merge 411666-pipeline-security-compact-pagination into master

What does this MR do and why?

Show compact pagination on pipeline security tab

The performance improvements behind the existing security_findings_finder_lateral_join were incorrectly disabling pagination on the Pipeline -> Security tab.

This change enables compact pagination on that page when the flag is enabled. We need compact pagination (i.e. without total counts) here because the performance improvements that are behind the feature flag do not support efficient count queries.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  1. Ensure the security_findings_finder_lateral_join feature flag is on" 
    Feature.enable(:security_findings_finder_lateral_join)
  2. Visit any Pipeline -> Security on a project with more than 20 findings.
  3. Check that the pagination controls are visible and working correctly on the list of findings.

Database plans

The finder change in this MR does not affect the query plan:

Before: https://console.postgres.ai/gitlab/gitlab-production-tunnel-pg12/sessions/24347/commands/77787 After: https://console.postgres.ai/gitlab/gitlab-production-tunnel-pg12/sessions/24347/commands/77789

Related to #411666 (closed)

Edited by Malcolm Locke

Merge request reports