Skip to content

Wait 1min for runner to finish in review-apps

David Dieulivol requested to merge ddieulivol-shorter_graceful_period_for_runner_review_apps into master

Context

Now that #431870 (closed) was closed, we can see that several kubernetes namespaces cannot be deleted in time because the gitlab runner pod cannot terminate in due time:

Looking at gitlab-runner#36786 (comment 1523285681), it seems to be expected.

What does this MR do and why?

Kill the gitlab runner pod after 1min instead of 1h (see docs about terminationGracePeriodSeconds)

Given it's for short-lived review-apps, we should be fine (e.g. we don't care about data loss).

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by David Dieulivol

Merge request reports