Ee 61988 collapse icon on merge request diff larger than profile picture
requested to merge ee-61988-collapse-icon-on-merge-request-diff-larger-than-profile-picture into master
What does this MR do?
- Changes the icon of the collapse icon in a diff from 24x24px to 19x19px to avoid elements jumping on the page after a click on the icon button.
- Is the EE port for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28512/
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team