Skip to content

Refactor Security MR Widget State Badge

Jannik Lehmann requested to merge update-badge-security-mr-widget into master

What does this MR do and why?

Solves: #432268 (closed)

  • This MR refactors the Security MR Widget State Badge to display a muted variant when the finding was dismissed.
  • It also refactors a bootstrap CSS class to use a GitLab UI utility class.

Screenshots or screen recordings

Before After
2023-11-20_13-38-23 2023-11-20_13-36-39

How to set up and validate locally

  1. Enable sast_reports_in_inline_diff
  2. Make sure your running an ultimate license or your GDK (how to)
  3. Clone this repo: https://gitlab.com/jannik_lehmann/sast-inline-findings-example
  4. Recreate this MR for SAST findings: jannik_lehmann/cq-and-sast-test!5 (diffs)
  5. Let the pipeline finish and the mr overview page.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports