Skip to content

Fix cross join in MembersFinder

Manoj M J [On PTO] requested to merge 419636-cells-fix-cross-joins-related-to-members-app-finders-members_finder-rb-96 into master

What does this MR do and why?

  • This MR fixes a cross join in MembersFinder, joining members (which is cell-local) to users (clusterwidee). This join turned out to be a redundant join, so we have fixed this by removing the JOIN completely. See discussion at !137387 (comment 1659548486).

  • Due to the removal of the existing allow_cross_joins_across_databases from MembersFinder, specs started failing elsewhere where this service was being used. This has also been taken care of - it has not been fixed, but it has been temporarily allowed. See note at !137387 (comment 1659548494)

Query plans

Before: https://postgres.ai/console/gitlab/gitlab-production-tunnel-pg12/sessions/24032/commands/76916

After: https://postgres.ai/console/gitlab/gitlab-production-tunnel-pg12/sessions/24032/commands/76918

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #419636 (closed)

Edited by Manoj M J [On PTO]

Merge request reports