Skip to content

Allow users to authenticate via OAuth with password-based providers

Drew Blessing requested to merge dblessing_ldap_oauth_fix into master

What does this MR do and why?

Related to #429484 (closed)

Allow users to authenticate via OAuth with password-based providers

Fix an issue caused by a recent change to allow users to authenticate with LDAP and Crowd (password-based authentication) through the OAuth API.

This is a somewhat naive change because it only validates that a given user has some password-based identity. It does not check whether that specific provider is enabled or not. If the user has a password-based provider identity for a provider that's disabled, the authentication process will also fail and the failed counter will be incremented. It's not a security risk, but the user could have their account locked if they repeatedly attempt to authenticate when their provider is disabled.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports