Skip to content

Add block to parent wigdet collapsible listbox

Rajan Mistry requested to merge 430143-parent-widget-overflow-issue into master

What does this MR do and why?

The block prop was removed in !134178 (comment 1623279416) as it was messing with styling but it also causes overflow issues and the sidebar glitches with it which was resolved in !134377 (merged). Adding block to parent widget helps to set a width and avoid overflows and glitches.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screen Recording 2023-11-16 at 6.33.58 PM.mov Screen Recording 2023-11-16 at 6.29.09 PM.mov

How to set up and validate locally

Prerequisites:

  1. Enable the OKRs feature as mentioned in the OKRs docs (e.g. ::Feature.enabled?(:okrs_mvc, Project.find(<PROJECT_ID>)) and the namespace must have Ultimate plan).

Steps to verify:

  1. Login with any user
  2. Go to any Project > Issues > List
  3. Create an new Objective under New issue split button
  4. Go to Objective detail page
  5. Interact with the Assignee widget to check if the sidebar is not shifted.

In addition to above flow, it also affects the Key results and Tasks feature.

For Key results/Tasks:

  1. Add a Key result/Task as mention Add a key result docs/Add a Task docs under an Objective/Issue
  2. Open the Key result/Task
  3. Interact with the Assignee widget to check if the sidebar is not shifted.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #430143 (closed)

Merge request reports