Skip to content

Remove unused code from merge request count manager

Lukas 'ai-pi' Eipert requested to merge leipert-remove-deprecated-sidebar-assignees into master

What does this MR do and why?

And related code. Currently we have two components (at least) for rendering an Assignee Widget in an issuable sidebar.

The more modern one sidebar_assignees_widget.vue is rendered if:

isInIssuePage() || isInDesignPage() || isInMRPage()

Which is all the pages with Issuables that have Assignees. Incidents seem to be "Issue" pages as well. Therefore we can remove the "else" code path and all the related code.

Screenshots or screen recordings

Before After
N/A Screen_Recording_2023-11-15_at_22.28.37

How to set up and validate locally

  1. Edit the assignees of Incidents, Merge Requests and Issues in the sidebar

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas 'ai-pi' Eipert

Merge request reports