Skip to content

GitLab Next

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 42,971
    • Issues 42,971
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,369
    • Merge requests 1,369
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !13703

Modify `DiffNote` to reuse it for Designs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bob Van Landuyt requested to merge reprazent/gitlab-ee:bvl-design-diff-notes into master May 30, 2019
  • Overview 29
  • Commits 1
  • Pipelines 8
  • Changes 17

What does this MR do?

This modifies the DiffNote model so we can create DiffNotes for DesignManagement::Designs.

It also includes some specs illustrating how the Notes::CreateService will need to be used from GraphQL for designs

This is part of the work for: https://gitlab.com/gitlab-org/gitlab-ee/issues/9489

CE changes in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29023

Does this MR meet the acceptance criteria?

Conformity

  • [-] Changelog entry Not user visible
  • [-] Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • [-] Database guides
  • Separation of EE specific content
Edited Dec 10, 2020 by 🤖 GitLab Bot 🤖
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bvl-design-diff-notes