Skip to content

Remove only_highlight_discussions_requested feature flag

Marc Shaw requested to merge 378605-mr-comments-not-loading-when-exceeding-about-50-comments into master

What does this MR do and why?

Remove only_highlight_discussions_requested feature flag. It has been turned on for atleast 11 days now.

Previously we were highlighting, and caching every discussion diff on the first request, this meant that the first request performed the majority of work, but when there were a lot of discussion diffs to highlight, it would timeout. With this change we now only highligh the discussion diffs that are involved in the response.

No performance degradation was noted, but reduction in errors was.

To test:

  • Create a merge request with 30+ diff comments
  • Ensure the diffs load as expected

Related to #378605 (closed)
Feature flag rollout to #429489 (closed)

Edited by Marc Shaw

Merge request reports