Skip to content

Add resolved Indicator for SAST Inline Findings

Jannik Lehmann requested to merge jnnkl-sast-inline-dismissed-badge into master

What does this MR do and why?

Add resolved Indicator for SAST Inline Findings

This commit solves: #429832 (closed) It adds a resolved indicator to the SAST Inline findings when the finding was already resolved.

EE: true

Screenshots or screen recordings

Before After
2023-10-30_16-21-50 2023-11-14_17-26-20

How to set up and validate locally

  1. Enable sast_reports_in_inline_diff
  2. Make sure your running an ultimate license or your GDK (how to)
  3. Clone this repo: https://gitlab.com/jannik_lehmann/sast-inline-findings-example
  4. Recreate this MR for SAST & CodeQuality findings: jannik_lehmann/cq-and-sast-test!5 (diffs)
  5. Let the pipeline finish and the go checkout the diff page.
  6. Reload page multiple times to see polling in action.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports