Skip to content
Snippets Groups Projects

Improve spec coverage for dependency proxy for containers

Merged Radamanthus Batnag requested to merge 431386-additional-specs into master
All threads resolved!

What does this MR do and why?

This was extracted from !129697 (merged).

That MR contained:

  • :one: changes to add scope checks when using a group access token for dependency proxy for containers
  • :two: refactorings related to the changes in :one:
  • :three: spec changes to add spec coverage, to increase confidence in the refactorings in :two:

!129697 (merged) had to be reverted because of a :bug: in :one:

!136655 (merged) will recreate the changes in !129697 (merged), plus the :bug: fixes. To reduce the scope of that MR, I extracted the changes in :three: into this MR. That MR will also need to re-reviewed by groupauthorization . I'm sure they'll appreciate the reduction in the MR they're going to re-review :sweat_smile:

Screenshots or screen recordings

No UI changes, these are spec-only changes :rainbow:

How to set up and validate locally

No behavior changes :rainbow:

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #431386

Edited by Radamanthus Batnag

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Moaz Khalifa
  • added 1 commit

    • 208963ac - Simplify loop through user types

    Compare with previous version

  • A deleted user added backend label

    added backend label

  • added 3 commits

    Compare with previous version

  • Moaz Khalifa approved this merge request

    approved this merge request

  • Moaz Khalifa requested review from @10io

    requested review from @10io

  • David Fernandez removed review request for @10io

    removed review request for @10io

  • added 3 commits

    • 246941d0 - Make context names more descriptive
    • 93f54b10 - Add tests for all other user types
    • 3eccc58c - Add spec on group access token with insufficient scopes

    Compare with previous version

  • Radamanthus Batnag requested review from @10io

    requested review from @10io

  • Radamanthus Batnag removed review request for @10io

    removed review request for @10io

  • Radamanthus Batnag added 992 commits

    added 992 commits

    Compare with previous version

  • Radamanthus Batnag requested review from @10io

    requested review from @10io

  • David Fernandez approved this merge request

    approved this merge request

  • David Fernandez resolved all threads

    resolved all threads

  • David Fernandez enabled an automatic merge when the pipeline for 84f2a2de succeeds

    enabled an automatic merge when the pipeline for 84f2a2de succeeds

  • David Fernandez mentioned in commit 1d025b8f

    mentioned in commit 1d025b8f

  • Radamanthus Batnag mentioned in merge request !136655 (merged)

    mentioned in merge request !136655 (merged)

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading