Improve spec coverage for dependency proxy for containers
What does this MR do and why?
This was extracted from !129697 (merged).
That MR contained:
-
changes to add scope checks when using a group access token for dependency proxy for containers -
refactorings related to the changes in -
spec changes to add spec coverage, to increase confidence in the refactorings in
!129697 (merged) had to be reverted because of a
!136655 (merged) will recreate the changes in !129697 (merged), plus the
Screenshots or screen recordings
No UI changes, these are spec-only changes
How to set up and validate locally
No behavior changes
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #431386
Merge request reports
Activity
changed milestone to %16.7
assigned to @radbatnag
added 447 commits
-
43237211...91029339 - 446 commits from branch
master
- dce7dab9 - Add specs for deploy token usage with dependency proxy
-
43237211...91029339 - 446 commits from branch
- A deleted user
added backend label
1 Warning 67f220ac: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @marcogreg
(UTC+8, same timezone as author)
@proglottis
(UTC+13, 5 hours ahead of author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved backend label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by David Fernandez
@mkhalifa3 Could you do the backend review for this MR if you have the capacity, please? Please pass to @dmeshcharakou or @10io for backend maintainer review.
requested review from @mkhalifa3
- Resolved by Radamanthus Batnag
- Resolved by Moaz Khalifa
- Resolved by Moaz Khalifa
- Resolved by Radamanthus Batnag
- A deleted user
added backend label
- Resolved by David Fernandez
@mkhalifa3
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
requested review from @10io
- Resolved by David Fernandez
- Resolved by David Fernandez
- Resolved by David Fernandez
removed review request for @10io
- Resolved by David Fernandez
requested review from @10io
removed review request for @10io
added 992 commits
-
3eccc58c...097dcdad - 985 commits from branch
master
- c1c95daa - Add specs for deploy token usage with dependency proxy
- 1db8e701 - Simplify loop through user types
- ad6cb732 - Remove unnecessary changes
- 79570f0f - Extract similar specs into a shared example
- 67f220ac - Rubocop fix
- bd5db31f - Make context names more descriptive
- e2f4d722 - Add tests for all other user types
Toggle commit list-
3eccc58c...097dcdad - 985 commits from branch
requested review from @10io
enabled an automatic merge when the pipeline for 84f2a2de succeeds
mentioned in commit 1d025b8f
mentioned in merge request !136655 (merged)
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in issue gitlab-org/quality/quality-engineering/team-tasks#2693 (closed)