Skip to content

Render submodules last to match backend pagination

Jerry Seto requested to merge 415711-repo-items-stuck-loading into master

What does this MR do and why?

Render submodules last to match backend pagination

The tree entries rendering with a different order than the order that they appear in pages from the backend causes the incorrect offsets to be marked as requested. We can bypass this issue by rendering tree entries in the same order as is returned by the backend.

More details here: #415711 (comment 1661438606)

Screenshots or screen recordings

Before After
Screenshot_2023-11-22_at_10.34.50_AM Screenshot_2023-11-22_at_10.35.01_AM

How to set up and validate locally

  1. Create a project with more than total of 25 directories and files in the root directory
  2. Add a submodule to the project
  3. From the project overview (e.g http://gdk.test:3000/root/lots_of_files_and_directories) scroll down and see that the last commit for the submodule loads

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #415711 (closed)

Edited by Jerry Seto

Merge request reports