Skip to content

Resets pagination on applying filter on Seats tab on Usage Quotas page

Vamsi Vempati requested to merge 344428-reset-pagination-on-filter into master

What does this MR do and why?

Resets pagination on applying filter on Seats tab on Usage Quotas page

  • Fixes a bug where searching from pages other than page 1 does not reset the pagination sometimes resulting in displaying an empty list for the search term despite having search results
  • Adds tests for actions

Related to #344428 (closed)

Screenshots or screen recordings

Before After
Screen_Recording_2023-11-14_at_4.38.12_PM Screen_Recording_2023-11-14_at_4.37.31_PM

How to set up and validate locally

Application setup

  1. Customers Dot needs to be setup in order to view the billing page for a group
  2. Start GDK in SaaS mode GITLAB_SIMULATE_SAAS=1 gdk start

Subscription setup

  1. Create a Group
  2. Go to Settings > Usage Quotas > Seats tab

Testing bug fix

  1. Add more than 20 members to the group to display pagination
  2. Navigate to second page (or any page other than page 1)
  3. Search for a term that has search results in the member list

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vamsi Vempati

Merge request reports