Skip to content

Improve vulnerability report filter text

What does this MR do and why?

Improves vulnerability report filter text. Specifically, it improves the text of the filter options for vulnerabilities that either do, or do not, have a solution available.

The UI text is:

  • Is available
  • Is not available

Although that is succinct, it's inconsistent with the UI text for the other filters. For each of them, each option's text includes the category name. See the image below for reference. The Issue filter options include the word issue, and the MR filter options include MR. The solution filter options' text does not include the word issue. This MR resolves that issue, to make them consistent with all other options.

image

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

  1. Have the related FF enabled: echo "Feature.enable(:activity_filter_has_remediations)" | rails c
  2. In order to run a pipeline to generate a Vulnerability report, you'll need an EE license.
  3. Fork https://gitlab.com/gitlab-org/govern/demos/sandbox/minac/test-remediations.
  4. Run a pipeline against the default branch. It will generate vulnerabilities.
  5. Go to the project vulnerability report page
  6. Select an "Activity" filter, it will have the new text for "Solution available" items

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Samantha Ming

Merge request reports