For 16.4: Fix Geo verification state backfill job can exceed batch size
What does this MR do and why?
Describe in detail what merge request is being backported and why
Backports !136275 (merged) to 16.4. For reference, here is the 16.5 backport.
This MR fixes the underlying code so that it does not return a batch that exceeds the specified batch size. This is expected to mitigate memory spikes.
Backport request: https://gitlab.com/gitlab-org/release/tasks/-/issues/7273
Related to #429242 (closed) and #430913 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. -
The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes). -
This MR has a severity label assigned (if applicable). -
This MR has been approved by a maintainer (only one approval is required). -
Ensure the e2e:package-and-test-ee
job has either succeeded or been approved by a Software Engineer in Test.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releases
Slack channel (internal only).
Merge request reports
Activity
assigned to @mkozono
changed milestone to %16.6
added backend bugperformance devopssystems groupgeo missed:16.5 severity2 typebug labels
added sectioncore platform label
changed milestone to %16.4
2 Warnings Backporting to older releases requires an exception request process The e2e:package-and-test-ee
job needs to succeed or have approval from a Software Engineer in Test.
Read the "QA e2e:package-and-test-ee" section for more details.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @akotte
(UTC+5.5, 15.5 hours ahead of
@mkozono
)@eurie
(UTC-5, 5 hours ahead of
@mkozono
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
QA
e2e:package-and-test-ee
@mkozono, the
package-and-test
job must complete before merging this merge request.*If there are failures on the
package-and-test
pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the#quality
Slack channel.If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerJust a heads up, the broken Puma jobs are known and being looked at.
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 516edb0bexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 34 | 0 | 0 | 0 | 34 | ✅ | | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Create | 38 | 0 | 0 | 0 | 38 | ✅ | | Data Stores | 20 | 0 | 0 | 0 | 20 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 12 | 0 | 1 | 0 | 13 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 163 | 0 | 1 | 0 | 164 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 516edb0bexpand test summary
+--------------------------------------------------------------+ | suites summary | +---------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +---------+--------+--------+---------+-------+-------+--------+ | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Create | 135 | 0 | 18 | 0 | 153 | ✅ | +---------+--------+--------+---------+-------+-------+--------+ | Total | 143 | 0 | 18 | 0 | 161 | ✅ | +---------+--------+--------+---------+-------+-------+--------+
mentioned in issue #430913 (closed)
- Resolved by Michael Kozono
@dbalexandre Would you please review?
It seems the stable branch is broken. I will be sure to rerun a pipeline and then E2E, after it is fixed.
requested review from @dbalexandre
removed review request for @dbalexandre
- Resolved by Michael Kozono
@dbalexandre
, thanks for approving this merge request.This is the first time the merge request has been approved. Please ensure the
e2e:package-and-test-ee
job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the#quality
Slack channel.
changed milestone to %16.7
added missed:16.4 label
mentioned in issue #429242 (closed)
mentioned in commit 9ab1c064
mentioned in merge request !136937 (merged)