Skip to content

Resolve "Fix alignments in work items"

Chad Lavimoniere requested to merge 431605-fix-alignments-in-work-items into master

What does this MR do and why?

Fixes alignment issues called out by @seggenberger in #431605 (closed) for consistency. Also adds a missing button tooltip and fixes an issue that caused some buttons not to show on touch screens.

Screenshots or screen recordings

Note: all After images below (except the mobile one) include hover on one of the items to make it easier to see spacing.

Tasks

Tasks used too much vertical spacing. the horizontal dividers were also removed.

Before After
Screenshot_2023-11-14_at_16.11.45 Screenshot_2023-11-14_at_16.27.14

The Remove button on tasks also was missing a tooltip:

Before After
Screenshot_2023-11-14_at_17.15.13 Screenshot_2023-11-14_at_17.15.29

On touch devices, Tasks also do not show the remove X button since the preference of the Plan team is to only show them on focus/hover. I added a quick boolean to ensure that they are shown by default on touch screens:

Before After
Screenshot_2023-11-14_at_17.25.08 Screenshot_2023-11-14_at_17.11.41

Child objectives and key results

Wrong alignment and spacing used

header header
Screenshot_2023-11-14_at_16.22.15 Screenshot_2023-11-14_at_16.26.04

Also wrong alignment on right side (and spacing) when there is a hierarchy

header header
Screenshot_2023-11-14_at_16.22.53 Screenshot_2023-11-14_at_16.28.46

How to set up and validate locally

  1. Check out this branch locally
  2. Navigate to an issue with Tasks
  3. Navigate to an Objective with child objectives

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #431605 (closed)

Edited by Chad Lavimoniere

Merge request reports