Remove usages of `gl-xs-flex-direction-column` CSS util
What does this MR do and why?
Remove usages of gl-xs-flex-direction-column
CSS util
This replaces usages of the desktop-first gl-xs-flex-direction-column
CSS util with
mobile-first alternatives.
Screenshots or screen recordings
There is no visual change as we are essentially reproducing the same layouts but with mobile-first utils instead of desktop-first ones. Here are a few screenshots for reference.
Subject | Mobile | Desktop |
---|---|---|
Abuse report header | ![]() |
![]() |
Abuse report content | ![]() |
![]() |
Abuse report activity | ![]() |
![]() |
Invite modal | ![]() |
![]() |
File browser header | ![]() |
![]() |
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.6
assigned to @pgascouvaillancourt
removed UX label
3 Warnings d68a5eb9: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. This merge request changed files with disabled eslint rules. Please consider fixing them. This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/registry/list_item.vue
app/assets/javascripts/vue_shared/components/usage_quotas/usage_banner.vue
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/vue_shared/components/registry/list_item.vue
app/assets/javascripts/vue_shared/components/usage_quotas/usage_banner.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/vue_shared/components/registry/list_item.vue' \ 'app/assets/javascripts/vue_shared/components/usage_quotas/usage_banner.vue'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @ibaum
(UTC-6, 1 hour behind author)
@stanhu
(UTC-8, 3 hours behind author)
frontend @fernando-c
(UTC-6, 1 hour behind author)
@xanf
(UTC+2, 7 hours ahead of author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
mentioned in issue gitlab-ui#2376 (closed)
- Resolved by Illya Klymov
@slashmanov could you review this please?
requested review from @slashmanov
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 114c6fb3 and d68a5eb9
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.1 MB 4.1 MB - 0.0 % mainChunk 3.06 MB 3.06 MB - 0.0 %
Note: We do not have exact data for 114c6fb3. So we have used data from: f4340bde.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for d68a5eb9expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Create | 40 | 0 | 7 | 0 | 47 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 201 | 0 | 10 | 0 | 211 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for d68a5eb9expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 8 | 0 | 2 | 0 | 10 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 6 | 0 | 26 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for d68a5eb9expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Manage | 40 | 0 | 10 | 14 | 50 | ❗ | | Create | 130 | 0 | 36 | 0 | 166 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 170 | 0 | 46 | 14 | 216 | ❗ | +--------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Userrequested review from @xanf and removed review request for @slashmanov
- Resolved by Illya Klymov
@slashmanov
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 12ed48ce succeeds
mentioned in commit 47104a78
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label