Skip to content
Snippets Groups Projects

Update MR approvals for SAML

Merged Nate Rosandich requested to merge nrosandich-master-patch-a068 into master
All threads resolved!

What does this MR do and why?

In MR Add optional SAML Auth requirement for MR approval (!130204 - merged) we are adding the ability to use SAML auth (if it is enabled) to approve MRs. Previously it was only possible to use password auth. This feature is currently on for gitlab.com, instance level SAML will be built next in this issue SAML SSO authentication for merge request appro... (#431415 - closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read removed review request for @eread

    removed review request for @eread

  • Nate Rosandich added 1 commit

    added 1 commit

    • 608888b1 - Apply 3 suggestion(s) to 1 file(s)

    Compare with previous version

  • Nate Rosandich requested review from @eread

    requested review from @eread

  • Nate Rosandich added 1 commit

    added 1 commit

    Compare with previous version

  • Nate Rosandich added 1 commit

    added 1 commit

    Compare with previous version

  • Evan Read
  • Evan Read
  • Evan Read approved this merge request

    approved this merge request

  • Evan Read added 1 commit

    added 1 commit

    • 654e4dd5 - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • Evan Read
  • Evan Read added 1 commit

    added 1 commit

    • 011741e0 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Evan Read resolved all threads

    resolved all threads

  • Evan Read enabled an automatic merge when the pipeline for 8b08b3fa succeeds

    enabled an automatic merge when the pipeline for 8b08b3fa succeeds

  • Nate Rosandich canceled the automatic merge

    canceled the automatic merge

  • SAM FIGUEROA mentioned in merge request !130204 (merged)

    mentioned in merge request !130204 (merged)

  • Nate Rosandich resolved all threads

    resolved all threads

  • Evan Read enabled an automatic merge when the pipeline for 4b43fb1a succeeds

    enabled an automatic merge when the pipeline for 4b43fb1a succeeds

  • merged

  • Evan Read mentioned in commit fbb61f43

    mentioned in commit fbb61f43

  • added workflowstaging label and removed workflowcanary label

  • Nate Rosandich mentioned in merge request !137074 (merged)

    mentioned in merge request !137074 (merged)

  • Please register or sign in to reply
    Loading