Update MR approvals for SAML
What does this MR do and why?
In MR Add optional SAML Auth requirement for MR approval (!130204 - merged) we are adding the ability to use SAML auth (if it is enabled) to approve MRs. Previously it was only possible to use password auth. This feature is currently on for gitlab.com, instance level SAML will be built next in this issue SAML SSO authentication for merge request appro... (#431415 - closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @nrosandich
changed milestone to %16.6
added docs-only documentation groupcompliance labels
added devopsgovern sectionsec labels
assigned to @eread
2 Warnings 7e0c6e31: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 5f6c18e1: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/merge_request_approvals.md
(Link to current live version) -
doc/user/project/merge_requests/approvals/settings.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@nrosandich - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
requested review from @eread
unassigned @eread
added typefeature label
- Resolved by Nate Rosandich
- Resolved by Nate Rosandich
- Resolved by Nate Rosandich
- Resolved by Nate Rosandich
added Technical Writing docsfeature maintenancerefactor typemaintenance labels and removed typefeature label
removed review request for @eread
requested review from @eread
- Resolved by Evan Read
- Resolved by Evan Read
- Resolved by Evan Read
enabled an automatic merge when the pipeline for 8b08b3fa succeeds
mentioned in merge request !130204 (merged)
enabled an automatic merge when the pipeline for 4b43fb1a succeeds
mentioned in commit fbb61f43
mentioned in merge request gitlab-com/www-gitlab-com!130804 (merged)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request !137074 (merged)