Skip to content
Snippets Groups Projects

Update feature flags default_enabled to true

Merged Jay Montal requested to merge 130354_update_ffs_default_to_true into master
All threads resolved!

What does this MR do and why?

What

  • Updates pending_status_check_responses default_enabled to true
  • Updates timeout_status_check_responses default_enabled to true

Why

Needed as part of the release post in gitlab-com/www-gitlab-com!130354 (merged)

Screenshots or screen recordings

No UI changes

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Contributor

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 455de5c9

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
    | Create           | 40     | 0      | 7       | 0     | 47    | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Verify           | 32     | 0      | 0       | 0     | 32    | ✅     |
    | Govern           | 48     | 0      | 0       | 0     | 48    | ✅     |
    | Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 201    | 0      | 10      | 0     | 211   | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 455de5c9

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Govern | 168    | 1      | 7       | 4     | 176   | ❌     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 168    | 1      | 7       | 4     | 176   | ❌     |
    +--------+--------+--------+---------+-------+-------+--------+
  • Drew Blessing approved this merge request

    approved this merge request

  • Drew Blessing resolved all threads

    resolved all threads

  • Drew Blessing enabled an automatic merge when the pipeline for cf127a15 succeeds

    enabled an automatic merge when the pipeline for cf127a15 succeeds

  • merged

  • Drew Blessing mentioned in commit 2c1c8950

    mentioned in commit 2c1c8950

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading