Skip to content

Fix spacing warnings in YAML files

Amy Qualls requested to merge aqualls-fix-yaml-spacing-backend into master

What does this MR do and why?

As part of working on !136388 (merged) I had trouble spotting the YAML file that had an error, because we had so many files with warnings. Separately, I've created Fix spacing warnings in deprecation files (!136505 - merged) for the files owned by the Technical Writing team, because they can be merged with less oversight.

This MR adds whitespace changes to:

  • .gitlab/ci/database.gitlab-ci.yml
  • .gitlab/ci/frontend.gitlab-ci.yml
  • .gitlab/ci/global.gitlab-ci.yml
  • .gitlab/ci/rails.gitlab-ci.yml
  • .gitlab/ci/review-apps/main.gitlab-ci.yml
  • .gitlab/ci/rules.gitlab-ci.yml
  • .gitlab/ci/templates/gem.gitlab-ci.yml
  • .gitlab/ci/test-on-gdk/main.gitlab-ci.yml
  • lib/gitlab/ci/templates/Cosign.gitlab-ci.yml

To see the job output and why I chose to act: https://gitlab.com/gitlab-org/gitlab/-/jobs/5494639235 or expand this section:

Find the one line that's an error
$ yamllint -d "{extends: default, rules: {line-length: disable, document-start: disable}}" $LINT_PATHS
.gitlab/ci/rules.gitlab-ci.yml
  934:47    warning  too few spaces before comment  (comments)
  1592:5    warning  comment not indented like content  (comments-indentation)
  1631:34   warning  too few spaces before comment  (comments)
  1687:47   warning  too few spaces before comment  (comments)
.gitlab/ci/frontend.gitlab-ci.yml
  70:67     warning  too few spaces before comment  (comments)
.gitlab/ci/rails.gitlab-ci.yml
  64:24     warning  too few spaces before comment  (comments)
  78:24     warning  too few spaces before comment  (comments)
  351:23    warning  too few spaces before comment  (comments)
  352:34    warning  too few spaces before comment  (comments)
  360:25    warning  too few spaces before comment  (comments)
  366:35    warning  too few spaces before comment  (comments)
  368:33    warning  too few spaces before comment  (comments)
  370:44    warning  too few spaces before comment  (comments)
  382:34    warning  too few spaces before comment  (comments)
  395:46    warning  too few spaces before comment  (comments)
  397:44    warning  too few spaces before comment  (comments)
  399:55    warning  too few spaces before comment  (comments)
  411:36    warning  too few spaces before comment  (comments)
  412:43    warning  too few spaces before comment  (comments)
  419:38    warning  too few spaces before comment  (comments)
  426:44    warning  too few spaces before comment  (comments)
  428:51    warning  too few spaces before comment  (comments)
  430:46    warning  too few spaces before comment  (comments)
  437:36    warning  too few spaces before comment  (comments)
  439:47    warning  too few spaces before comment  (comments)
  441:31    warning  too few spaces before comment  (comments)
  443:37    warning  too few spaces before comment  (comments)
  445:38    warning  too few spaces before comment  (comments)
  447:33    warning  too few spaces before comment  (comments)
.gitlab/ci/database.gitlab-ci.yml
  75:17     warning  too few spaces before comment  (comments)
.gitlab/ci/global.gitlab-ci.yml
  39:16     warning  too few spaces before comment  (comments)
  49:16     warning  too few spaces before comment  (comments)
  232:27    warning  too few spaces before comment  (comments)
  502:24    warning  too few spaces before comment  (comments)
.gitlab/ci/templates/gem.gitlab-ci.yml
  21:11     warning  comment not indented like content  (comments-indentation)
.gitlab/ci/test-on-gdk/main.gitlab-ci.yml
  30:25     warning  too few spaces before comment  (comments)
.gitlab/ci/review-apps/main.gitlab-ci.yml
  48:40     warning  too few spaces before comment  (comments)
  51:43     warning  too few spaces before comment  (comments)
  101:40    warning  too few spaces before comment  (comments)
  103:43    warning  too few spaces before comment  (comments)
lib/gitlab/ci/templates/Cosign.gitlab-ci.yml
  15:24     warning  too few spaces before comment  (comments)
  17:24     warning  too few spaces before comment  (comments)
data/deprecations/16-0-deprecate-omnibus-grafana.yml
  22:10     warning  too few spaces before comment  (comments)
data/deprecations/16-1-windows-cmd-runner-shell-executor.yml
  5:30      warning  too few spaces before comment  (comments)
  8:17      warning  too few spaces before comment  (comments)
  9:67      warning  too few spaces before comment  (comments)
  13:37     warning  too few spaces before comment  (comments)
data/deprecations/16-4-ci_job_token_scope_enabled-attribute-deprecation.yml
  10:67     warning  too few spaces before comment  (comments)
data/deprecations/16-1-unified-approval-rules.yml
  27:91     warning  too few spaces before comment  (comments)
data/deprecations/16-6-lfs-integrity-check-feature-flag-deprecation.yml
  10:1      error    trailing spaces  (trailing-spaces)
data/deprecations/  16_3_runner-terminationgracepriodseconds.yml
  1:95      warning  too few spaces before comment  (comments)
  2:29      warning  too few spaces before comment  (comments)
  3:34      warning  too few spaces before comment  (comments)
  4:26      warning  too few spaces before comment  (comments)
  5:22      warning  too few spaces before comment  (comments)
  6:16      warning  too few spaces before comment  (comments)
  17:34     warning  too few spaces before comment  (comments)
  21:36     warning  too few spaces before comment  (comments)
  22:81     warning  too few spaces before comment  (comments)
data/deprecations/16_2-custom_sign_in_fields.yml
  1:77      warning  too few spaces before comment  (comments)
  2:34      warning  too few spaces before comment  (comments)
  3:35      warning  too few spaces before comment  (comments)
  4:29      warning  too few spaces before comment  (comments)
  5:30      warning  too few spaces before comment  (comments)
  6:25      warning  too few spaces before comment  (comments)
  7:25      warning  too few spaces before comment  (comments)
  8:17      warning  too few spaces before comment  (comments)
  9:75      warning  too few spaces before comment  (comments)
Cleaning up project directory and file based variables
00:01
ERROR: Job failed: exit code 1

Related

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Amy Qualls

Merge request reports