Fixes a display bug in the new pipeline design
What does this MR do and why?
Fixes a display bug in the new pipeline design
Related to FF Pipeline: Redesigned Pipeline Graph (!132462 - merged)
Reported by @ayufan via Slack: https://gitlab.slack.com/archives/C05B0MER7LM/p1699456779173099
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Enable FF
new_pipeline_graph
- Go to a pipeline detail page with an upstream pipeline
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #425468 (closed)
Merge request reports
Activity
changed milestone to %16.6
assigned to @seggenberger
requested review from @pburdette
- Resolved by Payton Burdette
Hey @pburdette can you do the review here? TY!
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend @vvempati
(UTC+13, 12 hours ahead of author)
@pburdette
(UTC-5, 6 hours behind author)
~"Verify" Reviewer review is optional for ~"Verify" @mgandres
(UTC+8, 7 hours ahead of author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- 9fa36227 - Fixes a display bug in the new pipeline design
- Resolved by Payton Burdette
@pburdette
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 6da916ee succeeds
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 791de9e8 and 9fa36227
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.1 MB 4.1 MB - 0.0 % mainChunk 3.06 MB 3.06 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 9fa36227expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 40 | 0 | 7 | 0 | 47 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 201 | 0 | 10 | 0 | 211 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in commit 6e5e0637
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label