Skip to content

Adjusts stub_saas_features to stub defaults

Vijay Hawoldar requested to merge vij-stub-saas-feature-defaults into master

What does this MR do and why?

Previous to this MR, if we used stub_saas_features to stub one feature, but another was checked as part of an unrelated piece of code during execution, the test will fail due to an unexpected call to the class.

An example can be seen in this failed pipeline: https://gitlab.com/gitlab-org/gitlab/-/jobs/5498081484


So that we can test flows that result in multiple calls to Gitlab::Saas.feature_available?, this MR now stubs the default value for all known SaaS features to false (which matches the default expectation described in the example in our docs)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vijay Hawoldar

Merge request reports