Skip to content
Snippets Groups Projects

Fix tracing list sorting option

Merged Daniele Rossetti requested to merge rossetd/fix-tracing-sorting into master
All threads resolved!

What does this MR do and why?

Changed created_ tracing sorting param to timestamp_ , to align with the API spec. Only _desc is currently supported, but @mappelman is working on adding support for ascending order as we speak. (Note this feature is still WIP and behind feature flag, with no real customers yet.)

Screenshots or screen recordings

NA

How to set up and validate locally

  • Running the whole stack is not trivial, but I can prepare a VM if someone wants to test it.
  • Run tests

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Daniele Rossetti

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Artur Fedorov resolved all threads

    resolved all threads

  • Artur Fedorov enabled an automatic merge when the pipeline for b3f497a4 succeeds

    enabled an automatic merge when the pipeline for b3f497a4 succeeds

  • Daniele Rossetti requested review from @arfedoro and removed review request for @jivanvl

    requested review from @arfedoro and removed review request for @jivanvl

  • Jose Ivan Vargas approved this merge request

    approved this merge request

  • Jose Ivan Vargas resolved all threads

    resolved all threads

  • merged

  • Artur Fedorov mentioned in commit 8e539a4f

    mentioned in commit 8e539a4f

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading