Fix tracing list sorting option
What does this MR do and why?
Changed created_
tracing sorting param to timestamp_
, to align with the API spec. Only _desc
is currently supported, but @mappelman is working on adding support for ascending order as we speak. (Note this feature is still WIP and behind feature flag, with no real customers yet.)
Screenshots or screen recordings
NA
How to set up and validate locally
- Running the whole stack is not trivial, but I can prepare a VM if someone wants to test it.
- Run tests
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.6
assigned to @drosse
added frontend groupobservability + 1 deleted label
added typefeature label
added devopsanalyze sectionanalytics labels
requested review from @slashmanov
- Resolved by Jose Ivan Vargas
Hi @slashmanov ! got some time for a super quick review? Thanks!
FYI @mappelman
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 89b68405expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Create | 40 | 0 | 7 | 0 | 47 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 201 | 0 | 10 | 0 | 211 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
removed review request for @slashmanov
3 Warnings 89b68405: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. b83846a5: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. fbe2dc51: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend @agulina
(UTC+1, same timezone as author)
@arfedoro
(UTC+1, same timezone as author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 972a7813 and 89b68405
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.1 MB 4.1 MB - 0.0 % mainChunk 3.06 MB 3.06 MB - 0.0 %
Note: We do not have exact data for 972a7813. So we have used data from: 791de9e8.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerrequested review from @slashmanov
- Resolved by Artur Fedorov
@mappelman
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
LGTM @drosse!
requested review from @arfedoro and removed review request for @slashmanov
- Resolved by Artur Fedorov
enabled an automatic merge when the pipeline for b3f497a4 succeeds
mentioned in commit 8e539a4f
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label