Skip to content

Organization Users - Pagination

What does this MR do and why?

Work towards #409313 (closed)
Work Item: #410187 (closed)
GraphQL endpoint: !130017 (merged)

This change adds GlKeysetPagination to the Organization Users view.

This change is behind a feature flag (:ui_for_organizations)

note: The goal here is to re-use as much of the existing User Admin view as possible to ensure the experiences are consistent between an Organization's users and an instance's users

Screenshots or screen recordings

Screen_Recording_2023-11-07_at_2.11.09_PM

How to set up and validate locally

Without any User Data

  1. Enable FF in rails c Feature.enable(:ui_for_organizations)
  2. Go to Default Organization path (http://127.0.0.1:3000/-/organizations/default)
  3. In left nav, click Manage => Users
  4. Ensuring Loading icon temporarily and then once complete text that says "No users found" is on the screen
  5. Ensuring that Pagination does not show up

With User Data

  1. Enable FF in rails c Feature.enable(:ui_for_organizations)
  2. Add more than 20 users to the default organization via rails c
      (1..25).each do |i|
        Organizations::OrganizationUser.create!(user_id: i, organization_id: 1)
      end
  3. In left nav, click Manage => Users
  4. Ensuring Loading icon temporarily and then once complete the Users Table appears
  5. Ensuring that pagination works as you'd expect

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Zack Cuddy

Merge request reports