Fix issue_spec.rb flaky spec
What does this MR do and why?
Related #420772 (closed)
Also ran into this while working on !134456 (merged) and could not get it passing in the pipelines even though it's flakey
This MR made a few changes which contributed to fixing the flaky spec
- switching to
elastic_delete_by_query
trait, this deletes all indexed data in between contexts which helped - removed a spec that I think was passing (but shouldn't have been), will leave a note on the diff
- replaces references to
Sidekiq::Testing.inline!
withsidekiq_inline
trait - reorganizes the spec slightly to give better describe and context names
Screenshots or screen recordings
N/A
How to set up and validate locally
specs only
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Terri Chu